Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/httpd: symlink apache configuration to /etc/httpd/httpd.conf for use in the apachectl command #77326

Merged
merged 1 commit into from Jan 16, 2020

Conversation

@aanderse
Copy link
Contributor

@aanderse aanderse commented Jan 8, 2020

Motivation for this change
~> apachectl configtest
AH00543: httpd: bad user name daemon

The apachectl configtest command is using the example configuration provided by the apacheHttpd package, instead of the system generated configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

…r use in the apachectl command
@peti
peti approved these changes Jan 10, 2020
Copy link
Member

@peti peti left a comment

I am not particularly happy about the introduction of an impure global path, but I am not sure what would be a better way to accomplish the goal, i.e. allowing users to run apachectl configtest. If anyone has a better idea, I'd love to hear it. In the absence of suggestions, I suppose we could go this route.

@aanderse
Copy link
Contributor Author

@aanderse aanderse commented Jan 10, 2020

@peti I understand. The only reason I file this PR is because I now have a need for this and I haven't been able to come up with a better solution ☹️ Thanks for looking.

@aanderse
Copy link
Contributor Author

@aanderse aanderse commented Jan 11, 2020

ping @zimbatm who has been helpful when mulling over httpd related issues. Any better ideas?

@aanderse aanderse merged commit 7260d2e into NixOS:master Jan 16, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@aanderse aanderse deleted the aanderse:apacheHttpd branch Jan 16, 2020
@zimbatm
Copy link
Member

@zimbatm zimbatm commented Jan 16, 2020

sorry about the wait. I don't see a better solution so post-merge 👍

@aanderse
Copy link
Contributor Author

@aanderse aanderse commented Feb 2, 2020

@peti @zimbatm this finally occurred to me as an alternative: https://github.com/NixOS/nixpkgs/compare/master...aanderse:apachectl?expand=1

Worth a PR to cleanup /etc?

@zimbatm
Copy link
Member

@zimbatm zimbatm commented Feb 2, 2020

if you believe it's the right thing to do I would say go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.