Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: 71.0 -> 72.0 (and other firefox packages as well) #77331

Merged
merged 7 commits into from Jan 8, 2020

Conversation

@andir
Copy link
Member

@andir andir commented Jan 8, 2020

Motivation for this change

This bumps firefox and related package to the lastest version. The NSS update is required by Firefox 72 and accounts for ~8k rebuilds. This might be fine to just hit master instead of going through staging..

Things done
  • Tested using NixOS VM test
  • made @fpletz test it :)
@fpletz
fpletz approved these changes Jan 8, 2020
Copy link
Member

@fpletz fpletz left a comment

Forgot to mention that I had to cherry-pick the actual firefox bump from the 19.09 backport PR. Pushed. 😄

@fpletz
Copy link
Member

@fpletz fpletz commented Jan 8, 2020

Since the 19.09 PR #77292 was merged, we should merge this now too. I agree that we should target master. 👍

@fpletz fpletz merged commit d01cc96 into NixOS:master Jan 8, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nss on aarch64-linux Success
Details
nss on x86_64-darwin Success
Details
nss on x86_64-linux Success
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 8, 2020
firefox: 71.0 -> 72.0 (and other firefox packages as well)
(cherry picked from commit d01cc96)
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 8, 2020
…s, nss)

This reverts commit 5090d06.
@lheckemann
Copy link
Member

@lheckemann lheckemann commented Jan 9, 2020

2020-01-09-140056_screenshot
Not sure if it was this or 72.0.1, but the fonts in various parts of the UI look a bit funky now.

dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 21, 2020
…(rebuilds, nss)"

This reverts commit b9730ee.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.