Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cachix: fix dependencies #77333

Closed
wants to merge 1 commit into from
Closed

cachix: fix dependencies #77333

wants to merge 1 commit into from

Conversation

@LnL7
Copy link
Member

LnL7 commented Jan 8, 2020

Motivation for this change

Follow up on #77311.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

/cc @domenkozar

The tests currently depend on an old version of warp and jailbreaking
results in failing tests.
@domenkozar
Copy link
Member

domenkozar commented Jan 8, 2020

Will be fixed with Haskell merge on Friday. Is it worth fixing for two days?

@LnL7
Copy link
Member Author

LnL7 commented Jan 8, 2020

Unstable was unblocked just after this was added as an extra requirement.

@domenkozar
Copy link
Member

domenkozar commented Jan 9, 2020

Looks like unar needs fixing too: https://hydra.nixos.org/job/nixpkgs/trunk/unstable#tabs-constituents

cachix will get fixed with #76982 tomorrow

@domenkozar
Copy link
Member

domenkozar commented Jan 9, 2020

Seems to be fixed in #77336, cachix will get fixed tomorrow with #76982

@domenkozar domenkozar closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.