Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.coordinates: init at 0.4.0 #77335

Merged
merged 2 commits into from Jan 9, 2020
Merged

Conversation

@mildlyincompetent
Copy link
Contributor

mildlyincompetent commented Jan 8, 2020

Motivation for this change

Packaging coordinates, a python module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot added the 6.topic: python label Jan 8, 2020
@mildlyincompetent
Copy link
Contributor Author

mildlyincompetent commented Jan 8, 2020

@GrahamcOfBorg build python36Packages.coordinates python37Packages.coordinates python38Packages.coordinates

Copy link
Member

bcdarwin left a comment

Thanks! See a couple comments, mainly disabling for unsupported Pythons. Python 3 version build on my NixOS machine.

};

# No tests in PyPi source distribution.
doCheck = false;

This comment has been minimized.

Copy link
@bcdarwin

bcdarwin Jan 8, 2020

Member

I see you've requested these be bundled with the PyPi dist, but possibly consider switching to the GitHub release for now?

@bcdarwin
Copy link
Member

bcdarwin commented Jan 8, 2020

Also, please update the PR/commit message to a buildable package name, here python3Packages.coordinates: .... Thanks!

Copy link
Contributor

jonringer left a comment

Also, the commit message should be:

pythonPackages.coordinates: init at 0.4.0
@mildlyincompetent mildlyincompetent changed the title coordinates: init at 0.4.0 python3Packages.coordinates: init at 0.4.0 Jan 9, 2020
@mildlyincompetent
Copy link
Contributor Author

mildlyincompetent commented Jan 9, 2020

@GrahamcOfBorg build python3Packages.coordinates python36Packages.coordinates python37Packages.coordinates python38Packages.coordinates

@mildlyincompetent
Copy link
Contributor Author

mildlyincompetent commented Jan 9, 2020

Thanks for the advice everyone, I've

  • Switched to the github release, as that includes tests
  • Disabled for python 3.5 and below
  • Fixed the commit message

Let me know if there's anything further.

@mildlyincompetent mildlyincompetent requested review from bcdarwin and jonringer Jan 9, 2020
@mildlyincompetent mildlyincompetent requested a review from bcdarwin Jan 9, 2020
Copy link
Contributor

jonringer left a comment

diff LGTM
commits LGTM
has tests 👍

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77335
2 package were built:
python37Packages.coordinates python38Packages.coordinates
@jonringer
Copy link
Contributor

jonringer commented Jan 9, 2020

@GrahamcOfBorg build python37Packages.coordinates python38Packages.coordinates

@jonringer jonringer merged commit d84fb64 into NixOS:master Jan 9, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python37Packages.coordinates, python38Packages.coordinates on aarch64-linux Success
Details
python37Packages.coordinates, python38Packages.coordinates on x86_64-darwin Success
Details
python37Packages.coordinates, python38Packages.coordinates on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.