Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ultrastardx: 2017.8.0 -> 2019-01-07 #77365

Merged
merged 1 commit into from Jan 12, 2020
Merged

ultrastardx: 2017.8.0 -> 2019-01-07 #77365

merged 1 commit into from Jan 12, 2020

Conversation

@teto
Copy link
Contributor

@teto teto commented Jan 9, 2020

follow up of the fix provided in UltraStar-Deluxe/USDX#462
to use pkg-config to find lua.

cc @vcunat fbda7ca

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

];

in stdenv.mkDerivation rec {
pname = "ultrastardx";
version = "2017.8.0";
version = "07012019";

This comment has been minimized.

@flokli

flokli Jan 9, 2020
Contributor

You're sure about that version string?

This comment has been minimized.

@teto

teto Jan 9, 2020
Author Contributor

fixed as per the manual If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".

This comment has been minimized.

@flokli

flokli Jan 9, 2020
Contributor

I saw version = "unstable-YYYY-MM-DD"; more often than pname = "foo-unstable";. Can you change this?

Also, the commit message still contains the old version number.

This comment has been minimized.

@teto

teto Jan 9, 2020
Author Contributor

should be fine now

@teto teto force-pushed the teto:ultrastardx branch 4 times, most recently from 727cb7e to 103dd65 Jan 9, 2020
@teto teto changed the title ultrastardx: 2017.8.0 -> 07012019 ultrastardx: 2017.8.0 -> 2019-01-07 Jan 9, 2020
@flokli
flokli approved these changes Jan 9, 2020
follow up of the fix provided in UltraStar-Deluxe/USDX#462
to use pkg-config to find lua.
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 12, 2020

Ran nix-review on this pr and tested the resulting binary.

LGTM.

@teto teto merged commit 502c16e into NixOS:master Jan 12, 2020
16 checks passed
16 checks passed
ultrastardx on aarch64-linux No attempt
Details
ultrastardx on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ultrastardx on x86_64-linux Success
Details
@teto teto deleted the teto:ultrastardx branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.