Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] libxml2: add patch for CVE-2019-19956 #77366

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@markuskowa
Copy link
Member

markuskowa commented Jan 9, 2020

Motivation for this change

See #77265

Updating libxml2-2.9.9 to 2.9.10 on 19.09 seems to be too intrusive (#73178).

May also warrant backport to 19.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @volth @edolstra @NixOS/security-notifications

@markuskowa
Copy link
Member Author

markuskowa commented Jan 9, 2020

@GrahamcOfBorg build libxml2

@markuskowa markuskowa changed the title [19.09] libxml: add patch for CVE-2019-19956 [19.09] libxml2: add patch for CVE-2019-19956 Jan 10, 2020
@vcunat
vcunat approved these changes Jan 11, 2020
Copy link
Member

vcunat left a comment

👍 Memory leaks are getting "high" severity CVEs now :-)

vcunat added a commit that referenced this pull request Jan 11, 2020
... into staging-19.09
@vcunat vcunat mentioned this pull request Jan 11, 2020
0 of 1 task complete
@vcunat vcunat merged commit 4bbd82f into NixOS:release-19.09 Jan 13, 2020
16 checks passed
16 checks passed
libxml2 on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libxml2 on aarch64-linux Success
Details
libxml2 on x86_64-linux Success
Details
@markuskowa markuskowa deleted the markuskowa:fix-libxml2-1909 branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.