Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sha256 in python-hypothesis #77372

Open
wants to merge 1 commit into
base: staging
from
Open

Conversation

@nomeata
Copy link
Contributor

nomeata commented Jan 9, 2020

it looks like the version bump in
046c402 did not update the sha256

Also there was a dependency missing.

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 9, 2020

hmm, I remember doing all of this once, guess it was for my PR which got closed

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 9, 2020

however, this is a dependency of pytest, which is used by the majority of packages. Do you mind targeting the staging branch, as this causes a rebuild of most of the python packages.

@nomeata nomeata changed the base branch from master to staging Jan 9, 2020
@nomeata nomeata force-pushed the nomeata:hypothesis-sha branch from 15a4d04 to 85be7e2 Jan 9, 2020
@nomeata

This comment has been minimized.

Copy link
Contributor Author

nomeata commented Jan 9, 2020

Do you mind targeting the staging branch

done

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 9, 2020

@GrahamcOfBorg build python3Packages.requests python38Packages.requests

Copy link
Contributor

jonringer left a comment

oops, didn't look at commit message, it should be:

python3Packages.hypothesis: fix sha256
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 9, 2020

otherwise LGTM

it looks like the version bump in
046c402 did not update the sha256

Also there was a dependency missing.
@nomeata nomeata force-pushed the nomeata:hypothesis-sha branch from 85be7e2 to 1cabe6f Jan 10, 2020
@nomeata

This comment has been minimized.

Copy link
Contributor Author

nomeata commented Jan 10, 2020

rebased to fix commit message

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Jan 10, 2020

let's wait with merging. If the hash wasn't committed, then it wasn't tested.

@FRidh FRidh self-assigned this Jan 11, 2020
FRidh added a commit that referenced this pull request Jan 11, 2020
This updated only the version, not the hash.

#77372

This reverts commit 046c402.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.