Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sha256 in python-hypothesis #77372

Closed
wants to merge 1 commit into from
Closed

Conversation

@nomeata
Copy link
Contributor

@nomeata nomeata commented Jan 9, 2020

it looks like the version bump in
046c402 did not update the sha256

Also there was a dependency missing.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 9, 2020

hmm, I remember doing all of this once, guess it was for my PR which got closed

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 9, 2020

however, this is a dependency of pytest, which is used by the majority of packages. Do you mind targeting the staging branch, as this causes a rebuild of most of the python packages.

@nomeata nomeata changed the base branch from master to staging Jan 9, 2020
@nomeata nomeata force-pushed the nomeata:hypothesis-sha branch from 15a4d04 to 85be7e2 Jan 9, 2020
@nomeata
Copy link
Contributor Author

@nomeata nomeata commented Jan 9, 2020

Do you mind targeting the staging branch

done

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 9, 2020

@GrahamcOfBorg build python3Packages.requests python38Packages.requests

Copy link
Contributor

@jonringer jonringer left a comment

oops, didn't look at commit message, it should be:

python3Packages.hypothesis: fix sha256
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 9, 2020

otherwise LGTM

it looks like the version bump in
046c402 did not update the sha256

Also there was a dependency missing.
@nomeata nomeata force-pushed the nomeata:hypothesis-sha branch from 85be7e2 to 1cabe6f Jan 10, 2020
@nomeata
Copy link
Contributor Author

@nomeata nomeata commented Jan 10, 2020

rebased to fix commit message

@FRidh
Copy link
Member

@FRidh FRidh commented Jan 10, 2020

let's wait with merging. If the hash wasn't committed, then it wasn't tested.

@FRidh FRidh self-assigned this Jan 11, 2020
FRidh added a commit that referenced this pull request Jan 11, 2020
This updated only the version, not the hash.

#77372

This reverts commit 046c402.
@stale
Copy link

@stale stale bot commented Jul 9, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unpriviledged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale label Jul 9, 2020
@nomeata
Copy link
Contributor Author

@nomeata nomeata commented Jul 9, 2020

Looks like this has been fixed somewhen.

@nomeata nomeata closed this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.