Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-update: 1.5.2 -> 2.5.0 #77377

Merged
merged 2 commits into from Feb 17, 2020
Merged

cargo-update: 1.5.2 -> 2.5.0 #77377

merged 2 commits into from Feb 17, 2020

Conversation

@Br1ght0ne
Copy link
Contributor

@Br1ght0ne Br1ght0ne commented Jan 9, 2020

Motivation for this change

https://github.com/nabijaczleweli/cargo-update/releases/tag/v2.5.0

Things done

Changes in this PR:

  • Switch from carnix to buildRustPackage, adding Cargo.lock via cargoPatches
    Upstream seems to be reluctant adding it to the tree.
  • Add pkg-config to buildInputs (for openssl to be found)
  • Refactor
  • Add myself as a maintainer
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/r93n715hv599zh8gq6plamkh1cik8pbd-cargo-update-2.5.0	  37.0M
Notify maintainers

cc @Gerschtli


This change is Reviewable

Br1ght0ne added 2 commits Jan 9, 2020
Copy link
Contributor

@Gerschtli Gerschtli left a comment

Diff LGTM

@Br1ght0ne
Copy link
Contributor Author

@Br1ght0ne Br1ght0ne commented Jan 20, 2020

cc @marsam for merging. Thanks!

@marsam marsam merged commit 3285f0f into NixOS:master Feb 17, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
cargo-update on aarch64-linux Success
Details
cargo-update on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@marsam
Copy link
Contributor

@marsam marsam commented Feb 17, 2020

Thank you, and sorry for the delay

@Br1ght0ne
Copy link
Contributor Author

@Br1ght0ne Br1ght0ne commented Feb 17, 2020

No worries, thank you too! I'll address the gist on the next update.

@Br1ght0ne Br1ght0ne deleted the Br1ght0ne:cargo-update-2.5.0 branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.