Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.avro-python3: init at 1.8.2 #77379

Merged
merged 2 commits into from Jan 13, 2020
Merged

python3Packages.avro-python3: init at 1.8.2 #77379

merged 2 commits into from Jan 13, 2020

Conversation

@ktrsoft
Copy link

ktrsoft commented Jan 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

src = fetchPypi {
inherit pname version;
sha256 = "f82cf0d66189600b1e6b442f650ad5aca6c189576723dcbf6f9ce096eab81bd6";
};
Comment on lines +8 to +11

This comment has been minimized.

Copy link
@jonringer

jonringer Jan 9, 2020

Contributor

looks like the source distribution doesn't contain tests, it would be prefereable to check out from git hub. E.g fetchFromGitHub

This comment has been minimized.

Copy link
@ktrsoft

ktrsoft Jan 11, 2020

Author

If we try to fetch from github, then lot of other languages(like java, c, c++, ...) code is coming, which is not relevant.

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 9, 2020

also, commit message should be:

python3Packages.avro-python3: init at 1.8.2
@jonringer jonringer changed the title Add avro-python3 package to nixpkgs python3Packages.avro-python3: init at 1.8.2 Jan 9, 2020
@ofborg ofborg bot requested a review from shlevy Jan 11, 2020
Copy link
Contributor

jonringer left a comment

the commit history should be:

maintainers: add ktrsoft
python3Packages.avro-python3: init at 1.8.2
@ktrsoft

This comment has been minimized.

Copy link
Author

ktrsoft commented Jan 11, 2020

the commit history should be:

maintainers: add ktrsoft
python3Packages.avro-python3: init at 1.8.2

Can you please let me know, is there a way to change now?

@shlevy

This comment has been minimized.

Copy link
Member

shlevy commented Jan 11, 2020

@ktrsoft See "Amending the message of older or multiple commit messages" on https://help.github.com/en/github/committing-changes-to-your-project/changing-a-commit-message

@ktrsoft ktrsoft force-pushed the ktrsoft:master branch from 8180c0c to a2a0927 Jan 11, 2020
@ktrsoft

This comment has been minimized.

Copy link
Author

ktrsoft commented Jan 11, 2020

maintainers: add ktrsoft

@jonringer Fixed the commit messages as requested

@ktrsoft

This comment has been minimized.

Copy link
Author

ktrsoft commented Jan 11, 2020

@ktrsoft See "Amending the message of older or multiple commit messages" on https://help.github.com/en/github/committing-changes-to-your-project/changing-a-commit-message

@shlevy Thanks

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 11, 2020

whats the difference between avro and avro-python3? they seem to be at the same version number

@ktrsoft

This comment has been minimized.

Copy link
Author

ktrsoft commented Jan 12, 2020

whats the difference between avro and avro-python3? they seem to be at the same version number

avro is for python2

@shlevy
shlevy approved these changes Jan 13, 2020
@shlevy shlevy merged commit 244c89d into NixOS:master Jan 13, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 13, 2020
python3Packages.avro-python3: init at 1.8.2

(cherry picked from commit 244c89d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.