Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pandas: fix tests #77385

Merged
merged 1 commit into from Jan 9, 2020
Merged

Conversation

@jonringer
Copy link
Contributor

jonringer commented Jan 9, 2020

Motivation for this change

noticed it was broken

The default ordering behavior has changed with pd.NaT

Closes: #77357

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

The default ordering behavior has changed with pd.NAT
@jonringer jonringer requested a review from FRidh as a code owner Jan 9, 2020
@ofborg ofborg bot added the 6.topic: python label Jan 9, 2020
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Jan 9, 2020

@GrahamcOfBorg build pythonPackages.pandas
@GrahamcOfBorg build python3Packages.pandas
@GrahamcOfBorg build python38Packages.pandas

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Jan 9, 2020

fixes a broken build, merging

@jonringer jonringer merged commit 0726ab3 into NixOS:master Jan 9, 2020
21 of 22 checks passed
21 of 22 checks passed
python38Packages.pandas on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python38Packages.pandas on aarch64-linux Success
Details
python38Packages.pandas on x86_64-linux Success
Details
python3Packages.pandas on aarch64-linux Success
Details
python3Packages.pandas on x86_64-darwin Success
Details
python3Packages.pandas on x86_64-linux Success
Details
pythonPackages.pandas on aarch64-linux Success
Details
pythonPackages.pandas on x86_64-darwin Success
Details
pythonPackages.pandas on x86_64-linux Success
Details
@jonringer jonringer deleted the jonringer:fix-pandas-tests branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.