Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pylint-plugin-utils: init at 0.6 #77391

Merged

Conversation

@kamadorueda
Copy link
Member

kamadorueda commented Jan 9, 2020

Motivation for this change

A nice tool for building pylint plugins, required by packages like pylint-flask / pylint-django, and finally the prospector linter

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@kamadorueda kamadorueda requested review from FRidh and jonringer as code owners Jan 9, 2020
@kamadorueda

This comment has been minimized.

Copy link
Member Author

kamadorueda commented Jan 9, 2020

$ nix-review HEAD
usage: /nix/store/bcs73c29wcdgqmnfkgiwahylz38qhr38-nix-review-2.1.0/bin/nix-review
       [-h] {pr,rev,wip} ...
/nix/store/bcs73c29wcdgqmnfkgiwahylz38qhr38-nix-review-2.1.0/bin/nix-review: error: argument subcommand: invalid choice: 'HEAD' (choose from 'pr', 'rev', 'wip')
kamado:~/Documents/nixpkgs/pythonPackages.pylint-plugin-utils$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
$ git worktree add /home/kamado/.cache/nix-review/rev-3e70ca8f2a7d5d367733b06cccb729e3711c664e/nixpkgs 0726ab30f678988e8059c59734ee9c61e5980e1c
Preparing worktree (detached HEAD 0726ab30f67)
HEAD is now at 0726ab30f67 python3Packages.pandas: fix tests
$ nix-env -f /home/kamado/.cache/nix-review/rev-3e70ca8f2a7d5d367733b06cccb729e3711c664e/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 3e70ca8f2a7d5d367733b06cccb729e3711c664e
Updating 0726ab30f67..3e70ca8f2a7
Fast-forward
 pkgs/development/python-modules/pylint-plugin-utils/default.nix | 38 ++++++++++++++++++++++++++++++++++++++
 pkgs/top-level/python-packages.nix                              |  2 ++
 2 files changed, 40 insertions(+)
 create mode 100644 pkgs/development/python-modules/pylint-plugin-utils/default.nix
$ nix-env -f /home/kamado/.cache/nix-review/rev-3e70ca8f2a7d5d367733b06cccb729e3711c664e/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/kamado/.cache/nix-review/rev-3e70ca8f2a7d5d367733b06cccb729e3711c664e/build.nix
[1 built, 0.0 MiB DL]
2 package were built:
python37Packages.pylint-plugin-utils python38Packages.pylint-plugin-utils

$ nix-shell /home/kamado/.cache/nix-review/rev-3e70ca8f2a7d5d367733b06cccb729e3711c664e/shell.nix
innovation

[nix-shell:~/.cache/nix-review/rev-3e70ca8f2a7d5d367733b06cccb729e3711c664e]$ exit
$ git worktree prune
Copy link
Contributor

jonringer left a comment

diff LGTM
commits LGTM
has tests 👍 (even if trivial:

$ cat tests.py
import pylint_plugin_utils

)

[4 built, 25 copied (17.9 MiB), 4.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77391
2 package were built:
python37Packages.pylint-plugin-utils python38Packages.pylint-plugin-utils

Ironic that this has so little tests and is under the PyCQA org, seeing as their mission statement is Organization for code quality tools (and plugins) for the Python programming language

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 9, 2020

@GrahamcOfBorg build python37Packages.pylint-plugin-utils python38Packages.pylint-plugin-utils

@jonringer jonringer merged commit 2b7f4ed into NixOS:master Jan 9, 2020
15 of 16 checks passed
15 of 16 checks passed
python37Packages.pylint-plugin-utils, python38Packages.pylint-plugin-utils on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python37Packages.pylint-plugin-utils, python38Packages.pylint-plugin-utils on aarch64-linux Success
Details
python37Packages.pylint-plugin-utils, python38Packages.pylint-plugin-utils on x86_64-darwin Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.