Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pycodestyle: improve tests #77393

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@kamadorueda
Copy link
Member

kamadorueda commented Jan 9, 2020

  • This commit adjust the tests to the ones that are found in the
    tox.ini file for the specified version of the module
  • This means we'll have 3 tests in adition to the default one
Motivation for this change

found it while doing other things and wanted to contribute it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 9, 2020

over 5000 rebuilds, please target staging branch

@kamadorueda

This comment has been minimized.

Copy link
Member Author

kamadorueda commented Jan 9, 2020

over 5000 rebuilds, please target staging branch

is it r'^staging$' branch ? there are many r'^staging.*$' branches

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 9, 2020

correct, staging is what you want. The other's are in case there's need for a "workspace" for stabilizing packages on a given release channel

@lovesegfault

This comment has been minimized.

Copy link
Contributor

lovesegfault commented Jan 10, 2020

You need to rebase and filter out all this stuff you picked up when changing the base on GH

- This commit adjust the tests to the ones that are found in the
  tox.ini file for the specified version of the module
- This means we'll have 3 tests in adition to the default one
@kamadorueda kamadorueda force-pushed the kamadorueda:pythonPackages.pycodestyle branch from 24ee339 to 99b05ea Jan 10, 2020
@kamadorueda

This comment has been minimized.

Copy link
Member Author

kamadorueda commented Jan 10, 2020

You need to rebase and filter out all this stuff you picked up when changing the base on GH

thanks, I've rebased and force-pushed the branch

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 10, 2020

@GrahamcOfBorg build pythonPackages.pycodestyle
@GrahamcOfBorg build python35Packages.pycodestyle
@GrahamcOfBorg build python36Packages.pycodestyle
@GrahamcOfBorg build python37Packages.pycodestyle
@GrahamcOfBorg build python38Packages.pycodestyle
@GrahamcOfBorg build python39Packages.pycodestyle

@jonringer jonringer merged commit 55e980e into NixOS:staging Jan 10, 2020
31 checks passed
31 checks passed
python39Packages.pycodestyle on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python35Packages.pycodestyle on aarch64-linux Success
Details
python35Packages.pycodestyle on x86_64-darwin Success
Details
python35Packages.pycodestyle on x86_64-linux Success
Details
python36Packages.pycodestyle on aarch64-linux Success
Details
python36Packages.pycodestyle on x86_64-darwin Success
Details
python36Packages.pycodestyle on x86_64-linux Success
Details
python37Packages.pycodestyle on aarch64-linux Success
Details
python37Packages.pycodestyle on x86_64-darwin Success
Details
python37Packages.pycodestyle on x86_64-linux Success
Details
python38Packages.pycodestyle on aarch64-linux Success
Details
python38Packages.pycodestyle on x86_64-darwin Success
Details
python38Packages.pycodestyle on x86_64-linux Success
Details
python39Packages.pycodestyle on aarch64-linux Success
Details
python39Packages.pycodestyle on x86_64-linux Success
Details
pythonPackages.pycodestyle on aarch64-linux Success
Details
pythonPackages.pycodestyle on x86_64-darwin Success
Details
pythonPackages.pycodestyle on x86_64-linux Success
Details
@kamadorueda

This comment has been minimized.

Copy link
Member Author

kamadorueda commented Jan 10, 2020

what is to do next in order to have it in master ?

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 10, 2020

wait.

staging is to collect many packages which introduce large changes, then it goes to a branch in staging-next where stabilization occurs (fixing issues), once stable enough, it gets merged into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.