Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/zerotierone: prevent systemd from changing MAC address #77405

Open
wants to merge 1 commit into
base: master
from

Conversation

@danielfullmer
Copy link
Contributor

danielfullmer commented Jan 9, 2020

Motivation for this change

zerotier has been very flaky for me after this commit fe3da83. Somehow adding tap to boot.kernelModules was causing issues on cloud hosted instances--as well as in qemu.

While debugging, I found that systemd was sometimes changing the MAC address of the interface after it was brought up by zerotier. This is even without using systemd-networkd. This PR disables that behavior from systemd for zerotier interfaces.

Note that i'm not using the systemd.network.link.<name> option in my PR since it is only active when systemd.network.enable is set. It's not clear to me if this should be the case or not.

I have my own nixos test for zerotier here:
https://github.com/danielfullmer/nixos-config/blob/master/tests/zerotier/default.nix
It only works if this fix is used.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @obadz

@misuzu
misuzu approved these changes Jan 10, 2020
Copy link
Contributor

misuzu left a comment

I've had similar issue, outgoing ping requests was failing with Destination unreachable: Address unreachable and several restarts after boot was needed to make zerotier work and this problem seem to go away with this fix.

@aanderse

This comment has been minimized.

Copy link
Contributor

aanderse commented Jan 11, 2020

@danielfullmer for the last month or two I haven't been able to use zerotierone on my linode VPS because it stopped working for reasons unknown to me. This PR fixes that. Thank you 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.