Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protonvpn-cli-ng: init at 2.2.0 #77407

Merged
merged 1 commit into from Jan 17, 2020
Merged

Conversation

@jtcoolen
Copy link
Member

@jtcoolen jtcoolen commented Jan 10, 2020

Motivation for this change

This PR introduces a newer and enhanced version of the protonvpn-cli tool, written in Python (see https://github.com/ProtonVPN/protonvpn-cli-ng).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 16, 2020

This tool builds and executes for me locally on NixOS 👍

@jtcoolen jtcoolen force-pushed the jtcoolen:protonvpn-cli-ng branch from cfe96c4 to 8408128 Jan 16, 2020
@jtcoolen
Copy link
Member Author

@jtcoolen jtcoolen commented Jan 16, 2020

Thank you @worldofpeace for your review! I've updated the commit with your suggestions.

@@ -0,0 +1,34 @@
{ stdenv, lib, fetchFromGitHub, python, python3Packages, openvpn, dialog }:

This comment has been minimized.

@worldofpeace

worldofpeace Jan 16, 2020
Member

Suggested change
{ stdenv, lib, fetchFromGitHub, python, python3Packages, openvpn, dialog }:
{ stdenv, lib, fetchFromGitHub, python3Packages, openvpn, dialog }:
Copy link
Member

@worldofpeace worldofpeace left a comment

LGTM, giving approval early because the above is a nit.
Thanks for contributing

@jtcoolen jtcoolen force-pushed the jtcoolen:protonvpn-cli-ng branch from 8408128 to b45c4d2 Jan 16, 2020
@jtcoolen jtcoolen removed the request for review from Infinisil Jan 17, 2020
@jtcoolen
Copy link
Member Author

@jtcoolen jtcoolen commented Jan 17, 2020

The unused dependency is now removed!

@worldofpeace worldofpeace merged commit 40bef24 into NixOS:master Jan 17, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
protonvpn-cli-ng on aarch64-linux Success
Details
protonvpn-cli-ng on x86_64-linux Success
Details
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 17, 2020

Merged, thanks again @jtcoolen.

@jtcoolen jtcoolen deleted the jtcoolen:protonvpn-cli-ng branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.