Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old gradle versions #77417

Merged
merged 4 commits into from Jan 10, 2020
Merged

remove old gradle versions #77417

merged 4 commits into from Jan 10, 2020

Conversation

@petabyteboy
Copy link
Member

@petabyteboy petabyteboy commented Jan 10, 2020

Motivation for this change

As noted in #58528, it would be nice to remove old gradle versions.
In #75546 the dependency for an old gradle version was removed in jd-gui, but this was done by downloading gradle via the gradle wrapper in a fixed-output derivation, which is not nice and can be avoided.
The last remaining culprit was mxisd, which seems to build fine with latest gradle too, and the NixOS test for it also ran fine, but the @MGuenter should check again that it does not cause more subtle problems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc gradle @groodt @xeji
cc jd-gui @averelld
cc mxisd @mguentner

petabyteboy added 4 commits Jan 10, 2020
It builds just fine with the packaged gradle, no reason to pull in
another impure dependency.
@petabyteboy
Copy link
Member Author

@petabyteboy petabyteboy commented Jan 10, 2020

I missed that mxisd was already using gradle 4, so it would not have been necessary to bump that. If the maintainers agree I would still use gradle 5 for that since it seems to work fine.

@ofborg ofborg bot added the 8.has: clean-up label Jan 10, 2020
@ofborg ofborg bot requested review from thoughtpolice and mguentner Jan 10, 2020
@petabyteboy petabyteboy mentioned this pull request Jan 10, 2020
5 of 13 tasks complete
@averelld
Copy link
Contributor

@averelld averelld commented Jan 10, 2020

Nice cleanup, 👍 from me. Although upstream jd-gui uses the wrapper, so we'll have to adjust manually occasionally I suppose, but can't be helped.

@petabyteboy
Copy link
Member Author

@petabyteboy petabyteboy commented Jan 10, 2020

Nice cleanup, from me. Although upstream jd-gui uses the wrapper, so we'll have to adjust manually occasionally I suppose, but can't be helped.

Actually that is also fixed in #77422, but that is a bigger story with some todos left
(gradle2nix solves this by packaging the exact gradle version which would be downloaded by the wrapper on the fly and saving it's version and hash in the gradle-env.json file)

@flokli flokli merged commit f29e259 into NixOS:master Jan 10, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gradle, jd-gui, mxisd on aarch64-linux Success
Details
gradle, jd-gui, mxisd on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@flokli
Copy link
Contributor

@flokli flokli commented Jan 10, 2020

🔥

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.