Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xen: build EFI binaries and drop unsupported versions #77421

Open
wants to merge 2 commits into
base: master
from

Conversation

@Shados
Copy link
Contributor

@Shados Shados commented Jan 10, 2020

Motivation for this change

#60485 has been going nowhere, so I'm closing that in favour of trying sequential, staggered PRs for the individual changes. This PR builds EFI binaries for Xen, and drops Xen 4.5 and 4.8, both of which are entirely EOL/unsupported upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra @oxij

@JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Feb 9, 2020

The build fails on ofBorg, can you please check that?
And also you need to rebase it on top of the latest master.

@Shados Shados force-pushed the Shados:xen-build-efi-binaries branch 2 times, most recently from e1440d8 to 2458f0c Feb 13, 2020
@Shados Shados force-pushed the Shados:xen-build-efi-binaries branch from 2458f0c to fdc0bcf Mar 3, 2020
@Shados
Copy link
Contributor Author

@Shados Shados commented Mar 3, 2020

Fixed the build process, still need to get around to testing the produced EFI binary.

@Shados Shados force-pushed the Shados:xen-build-efi-binaries branch from fdc0bcf to 27230f6 Mar 3, 2020
@Shados
Copy link
Contributor Author

@Shados Shados commented Mar 4, 2020

Did some testing, boots fine.

@Shados Shados force-pushed the Shados:xen-build-efi-binaries branch from 27230f6 to d9c85c1 Mar 18, 2020
@mt-caret mt-caret requested a review from oxij Jun 27, 2020
@mt-caret
Copy link
Contributor

@mt-caret mt-caret commented Oct 10, 2020

@Shados Thank you so much for working on this! Are there any blockers for merging this PR, or is this just waiting for review? I would love for this to be in nixpkgs...

@Shados
Copy link
Contributor Author

@Shados Shados commented Oct 10, 2020

Well, I expect there's likely been some bitrot since the last time I updated it, so I'll rebase again and see.

@Shados Shados force-pushed the Shados:xen-build-efi-binaries branch from d9c85c1 to 22fdd24 Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.