Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otter-browser: remove #77426

Merged
merged 1 commit into from Feb 2, 2020
Merged

otter-browser: remove #77426

merged 1 commit into from Feb 2, 2020

Conversation

@lheckemann
Copy link
Member

@lheckemann lheckemann commented Jan 10, 2020

Motivation for this change

I have no interest in maintaining this anymore and it has no other maintainers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@aanderse
Copy link
Contributor

@aanderse aanderse commented Jan 10, 2020

While I understand how in the long term distro unmaintained software is a big problem I think this might be a bit hasty. Several other people have been updating or fixing this package and we don't know that someone else wouldn't step up to maintain it if they knew you didn't want to. If the package is currently working and supported upstream can we just remove your name and look for a new maintainer?

@flokli
Copy link
Contributor

@flokli flokli commented Jan 10, 2020

Previous contributors: @aanderse, @dtzWill - would you be interested in taking over maintainership?

@lheckemann
Copy link
Member Author

@lheckemann lheckemann commented Jan 11, 2020

@aanderse sure, I didn't make this pull request with the absolute intention of removing otter from nixpkgs—more to signal that I no longer plan to maintain it, and call for anyone who might be using it to take up maintainership :) and if nobody steps up, we can remove it and then if someone misses it they can make a new PR reverting it and adding themselves as a maintainer.

@aanderse
Copy link
Contributor

@aanderse aanderse commented Jan 11, 2020

@lheckemann I think raising an issue + discourse thread + possibly mentioning on IRC is going to have much better chances of finding a new maintainer than creating a PR to remove the software with no mention of looking for a maintainer.

That being said... unmaintained software is bad so definitely better you create this PR than quietly ignore the package.

I'll post a thread on discourse to see if there are any takers.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Jan 11, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/packages-looking-for-a-maintainer/5442/1

@flokli
Copy link
Contributor

@flokli flokli commented Feb 2, 2020

I didn't really see somebody stepping up to maintain it. Unmaintained packages in nixpkgs are a problem, browsers even more given their exposure, which is why I'm inclined merging this.

@aanderse
Copy link
Contributor

@aanderse aanderse commented Feb 2, 2020

Unfortunate, but given the circumstances I agree.

I have no interest in maintaining this anymore and it has no other maintainers.
@flokli flokli force-pushed the lheckemann:remove-otter branch from 54db77c to c99e248 Feb 2, 2020
@flokli
Copy link
Contributor

@flokli flokli commented Feb 2, 2020

@lheckemann added the alias.

@flokli flokli merged commit a1bcf2c into NixOS:master Feb 2, 2020
@lheckemann lheckemann deleted the lheckemann:remove-otter branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.