Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry: 1.0.0 -> 1.0.1 #77437

Merged
merged 2 commits into from Jan 10, 2020
Merged

poetry: 1.0.0 -> 1.0.1 #77437

merged 2 commits into from Jan 10, 2020

Conversation

@adisbladis
Copy link
Member

adisbladis commented Jan 10, 2020

Motivation for this change

Also bumps poetry2nix although not strictly required.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zimbatm

This comment has been minimized.

Copy link
Member

zimbatm commented Jan 10, 2020

I am getting this error:

$ nix-build -A poetry
error: opening file '/home/zimbatm/.cache/nixpkgs-review/pr-77437/nixpkgs/pkgs/development/tools/poetry/src.json': No such file or directory
(use '--show-trace' to show detailed location information)
@adisbladis adisbladis force-pushed the adisbladis:poetry-1_0_1 branch from fb271f6 to 35dbd0c Jan 10, 2020
adisbladis added 2 commits Jan 10, 2020
@adisbladis adisbladis force-pushed the adisbladis:poetry-1_0_1 branch from 35dbd0c to e493969 Jan 10, 2020
@adisbladis

This comment has been minimized.

Copy link
Member Author

adisbladis commented Jan 10, 2020

@zimbatm Whoops, forgot to commit some new files.

@ofborg ofborg bot requested a review from jbaum98 Jan 10, 2020
@zimbatm zimbatm merged commit e639d3e into NixOS:master Jan 10, 2020
15 of 16 checks passed
15 of 16 checks passed
poetry on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
poetry on aarch64-linux Success
Details
poetry on x86_64-darwin Success
Details
@zimbatm

This comment has been minimized.

Copy link
Member

zimbatm commented Jan 10, 2020

tested with nixpkgs-review

@zimbatm

This comment has been minimized.

Copy link
Member

zimbatm commented Jan 10, 2020

@adisbladis you might want to set the updateScript as well like that:

passthru = {
updateScript = pantheon.updateScript {
attrPath = "pantheon.${pname}";
};
};

@retrry

This comment has been minimized.

Copy link
Contributor

retrry commented Jan 10, 2020

1.0.2 is already released with one PR reverted.

@adisbladis

This comment has been minimized.

Copy link
Member Author

adisbladis commented Jan 10, 2020

@retrry I pushed that bump straight to master, it's already there :)

@retrry

This comment has been minimized.

Copy link
Contributor

retrry commented Jan 13, 2020

I don't want to create issue for stupid questions, but why there are two poetry instances? One is 1.0.2, the other is still 0.2.17?

https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/poetry/default.nix

@adisbladis

This comment has been minimized.

Copy link
Member Author

adisbladis commented Jan 13, 2020

@retrry One is manually packaged in the pythonPackages set, one is automatically packaged with poetry2nix as a separate derivation not tied to what's in pythonPackages.

I'm not sure what to do with the one in pythonPackages, I don't consider that one a very useful derivation.

@adisbladis

This comment has been minimized.

Copy link
Member Author

adisbladis commented Jan 13, 2020

I don't want to create issue for stupid questions, but why there are two poetry instances? One is 1.0.2, the other is still 0.2.17?

https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/poetry/default.nix

@retrry I've made a PR addressing this: #77629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.