Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portfolio: init at 0.46.3 #77438

Merged
merged 1 commit into from May 17, 2020
Merged

portfolio: init at 0.46.3 #77438

merged 1 commit into from May 17, 2020

Conversation

@elohmeier
Copy link
Contributor

elohmeier commented Jan 10, 2020

Motivation for this change

Portfolio Performance package not available in nixpkgs.
Fixes #35267.

Things done

Packaged Portfolio Performance.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@elohmeier elohmeier force-pushed the elohmeier:portfolio branch from ae452a2 to 67e6d4a Jan 10, 2020
@elohmeier elohmeier force-pushed the elohmeier:portfolio branch from 67e6d4a to 5db6999 Jan 10, 2020
@elohmeier elohmeier force-pushed the elohmeier:portfolio branch from 5db6999 to 19ac7f6 Feb 7, 2020
@elohmeier elohmeier force-pushed the elohmeier:portfolio branch from 19ac7f6 to bfad122 Apr 15, 2020
@elohmeier elohmeier changed the title portfolio: init at 0.43.1 portfolio: init at 0.46.1 Apr 15, 2020
@elohmeier
Copy link
Contributor Author

elohmeier commented Apr 15, 2020

Updated to the latest version (which dropped i686 support) and setup the webbrowser dependency for the holding diagram. Thanks @0xbe7a for your help :-)

@elohmeier elohmeier force-pushed the elohmeier:portfolio branch from bfad122 to 1a611c4 Apr 28, 2020
@elohmeier
Copy link
Contributor Author

elohmeier commented Apr 28, 2020

Rebased onto latest master & configured generic jre.

@elohmeier elohmeier requested a review from oyren Apr 28, 2020
@elohmeier
Copy link
Contributor Author

elohmeier commented May 14, 2020

@oyren @0xbe7a could you approve this PR? I think that would help getting it merged.

@elohmeier elohmeier changed the title portfolio: init at 0.46.1 portfolio: init at 0.46.3 May 14, 2020
@elohmeier elohmeier force-pushed the elohmeier:portfolio branch from 1a611c4 to d1efd27 May 14, 2020
@elohmeier
Copy link
Contributor Author

elohmeier commented May 14, 2020

Updated to the latest version 0.46.3.

@0xbe7a
0xbe7a approved these changes May 14, 2020
Copy link
Contributor

oyren left a comment

Hey with KDE I had the following error when opening a file, which led to a crash of the application:
(Portfolio Performance:25632): GLib-GIO-ERROR **: No GSettings schemas are installed on the system
With the suggested changes the application ran without problems except for some warnings like:

(Portfolio Performance:26694): dconf-WARNING **:  failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

(Portfolio Performance:26694): Gtk-WARNING **: Negative content height -7 (allocation 3, extents 5x5) while allocating gadget (node scrollbar, owner GtkScrollbar)

(Portfolio Performance:26694): Gtk-CRITICAL **:  gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkScrollbar

@elohmeier elohmeier force-pushed the elohmeier:portfolio branch from d1efd27 to beaed5b May 16, 2020
@elohmeier
Copy link
Contributor Author

elohmeier commented May 16, 2020

@oyren Thanks for your test and review! I've updated the PR and included your suggested changes.

@oyren oyren self-requested a review May 16, 2020
@oyren
oyren approved these changes May 16, 2020
Copy link
Contributor

oyren left a comment

Thanks, @elohmeier. It works fine now.

@nixos-discourse
Copy link

nixos-discourse commented May 17, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/157

@AndersonTorres AndersonTorres merged commit f0b0bda into NixOS:master May 17, 2020
16 checks passed
16 checks passed
portfolio, portfolio.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="beaed5b"; rev="beaed5b544e8709dbc41dc64dd1bc2b66c029b18"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="beaed5b"; rev="beaed5b544e8709dbc41dc64dd1bc2b66c029b18"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="beaed5b"; rev="beaed5b544e8709dbc41dc64dd1bc2b66c029b18"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="beaed5b"; rev="beaed5b544e8709dbc41dc64dd1bc2b66c029b18"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="beaed5b"; rev="beaed5b544e8709dbc41dc64dd1bc2b66c029b18"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="beaed5b"; rev="beaed5b544e8709dbc41dc64dd1bc2b66c029b18"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="beaed5b"; rev="beaed5b544e8709dbc41dc64dd1bc2b66c029b18"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
portfolio, portfolio.passthru.tests on x86_64-linux Success
Details
@elohmeier elohmeier deleted the elohmeier:portfolio branch Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.