Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/tests: Fix module tests #77445

Merged
merged 1 commit into from Jan 10, 2020
Merged

lib/tests: Fix module tests #77445

merged 1 commit into from Jan 10, 2020

Conversation

@Infinisil
Copy link
Member

@Infinisil Infinisil commented Jan 10, 2020

Motivation for this change

Fix the broken test in #77416

Apparently hydra uses nix-build lib/tests/release.nix to run all
tests, where IFD isn't allowed. Fortunately we can get around this with
builtins.toFile, which doesn't require IFD, but still can test the
properties we want.

Ping @LnL7

Things done
  • Ran nix-build lib/tests/release.nix
  • Ran the same command after git revert e0ea5f4 (the fix for the broken tests) and it fails
Fix the broken test in #77416

Apparently hydra uses `nix-build lib/tests/release.nix` to run all
tests, where IFD isn't allowed. Fortunately we can get around this with
builtins.toFile, which doesn't require IFD, but still can test the
properties we want.
@Infinisil Infinisil requested review from edolstra and nbp as code owners Jan 10, 2020
@LnL7
LnL7 approved these changes Jan 10, 2020
@LnL7 LnL7 merged commit 112eea6 into NixOS:master Jan 10, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Checking new out paths
Details
@Infinisil Infinisil deleted the Infinisil:fix-lib-tests branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.