Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefoxPackages.icecat: mark as insecure #77463

Merged
merged 1 commit into from Jan 10, 2020
Merged

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Jan 10, 2020

It's based on 60.3.0, whose support ended around October 2019.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
It's based on 60.3.0, whose support ended around October 2019.
@flokli flokli requested a review from andir Jan 10, 2020
@andir andir merged commit 566780f into NixOS:master Jan 10, 2020
@flokli flokli deleted the flokli:icecat-mark-insecure branch Jan 10, 2020
@flokli flokli mentioned this pull request Jan 10, 2020
0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.