Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.discordpy: 1.2.4 -> 1.2.5, enable, add import checks #77465

Merged
merged 1 commit into from Jan 11, 2020

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 10, 2020

Motivation for this change

closes: #77457

they are better about updating their dependencies

cc @Th0rgal

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Th0rgal
Copy link
Contributor

@Th0rgal Th0rgal commented Jan 11, 2020

Hello, thank you for the PR! I tried to install it but it didn't work though. :(
I cloned your file discordpy.nix into my .config/nixpkgs folder (home-manager) and I tried to build it that way:

let
  my-python-packages = python-packages: with python-packages; [
    aiohttp
    pywal
    pygame
    pillow
    requests
    (pkgs.callPackage ./discordpy.nix)
  ];
  python-with-my-packages = python3.withPackages my-python-packages;

I've got the other packages but not discordpy: I'm not able to use import discord.
Did I do something wrong?
Here is my entire configuration: https://github.com/Th0rgal/zeus-nix-home

Thank you!

edit: sorry it was my fault, I forgot the braces

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Jan 11, 2020

not really sure about the setup, but importing works:

[2 built (1 failed), 2 copied (0.8 MiB), 0.2 MiB DL]
error: build of '/nix/store/r1zpj6mi1g5ybalnrh30kmfrmiagbdmb-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77465
1 package failed to build:
python38Packages.discordpy

1 package built:
python37Packages.discordpy

[0.0 MiB DL]
error: build log of '/nix/store/mvql2m09sii1fiyk1mn9c0ljvw7bxvwf-python3.8-discord.py-1.2.5.drv' is not available
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-77465/shell.nix

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-77465]$ python
Python 3.7.6 (default, Dec 18 2019, 19:23:55)
[GCC 9.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import discord
>>>
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Jan 11, 2020

failures are from python38Packages.aiohttp

[2 built (1 failed), 2 copied (0.8 MiB), 0.2 MiB DL]
error: build of '/nix/store/r1zpj6mi1g5ybalnrh30kmfrmiagbdmb-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77465
1 package failed to build:
python38Packages.discordpy

1 package built:
python37Packages.discordpy
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Jan 11, 2020

@GrahamcOfBorg build python37Packages.discordpy

@jonringer jonringer merged commit 27582b6 into NixOS:master Jan 11, 2020
15 of 16 checks passed
15 of 16 checks passed
python37Packages.discordpy on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python37Packages.discordpy on aarch64-linux Success
Details
python37Packages.discordpy on x86_64-darwin Success
Details
@jonringer jonringer deleted the jonringer:bump-discordpy branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.