Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paperless, python.pkgs.django_extensions #77470

Merged
merged 3 commits into from Jan 13, 2020

Conversation

@erikarvstedt
Copy link
Member

@erikarvstedt erikarvstedt commented Jan 10, 2020

python.pkgs.django_extensions is a dependency of paperless and python3Packages.hyperkitty, which is still broken for other reasons.

@@ -16,6 +16,13 @@ buildPythonPackage rec {
sha256 = "0053yqq4vq3mwy7zkfs5vfm3g8j9sfy3vrc6xby83qlj9wz43ipi";
};

patches = [

This comment has been minimized.

@jonringer

jonringer Jan 10, 2020
Contributor

do you mind adding a comment so it's easy to review is this is still applicable in future updates

Suggested change
patches = [
patches = [
# fixes issue with ...., should be able to be removed in next release
@erikarvstedt
Copy link
Member Author

@erikarvstedt erikarvstedt commented Jan 10, 2020

@GrahamcOfBorg test paperless

@erikarvstedt erikarvstedt force-pushed the erikarvstedt:fix-paperless branch from 84db43d to 7da3864 Jan 10, 2020
] ++ (optional cfg.consumptionDirIsPublic
"d '${cfg.consumptionDir}' 777 ${cfg.user} ${cfg.user} - -"
"d '${cfg.consumptionDir}' 777 ${cfg.user} ${group} - -"

This comment has been minimized.

@alyssais

alyssais Jan 12, 2020
Member

If this directory is 777 anyway (which is an… interesting choice), why not just make it root:root so you don’t have to worry about users?

This comment has been minimized.

@erikarvstedt

erikarvstedt Jan 12, 2020
Author Member

Yeah, that's simpler and functionally equivalent for our use case.

@erikarvstedt erikarvstedt force-pushed the erikarvstedt:fix-paperless branch 2 times, most recently from 1846b94 to 96a8833 Jan 12, 2020
Copy link
Member

@alyssais alyssais left a comment

Please autosquash :)

@erikarvstedt erikarvstedt force-pushed the erikarvstedt:fix-paperless branch from 96a8833 to e89db5d Jan 12, 2020
This removes a warning.
Previously, the service expected the paperless user to have a group with
the user's name. This is not necessarily the case for custom users.
@erikarvstedt erikarvstedt force-pushed the erikarvstedt:fix-paperless branch from e89db5d to 7b7dcf3 Jan 12, 2020
@alyssais alyssais merged commit 9ed03f2 into NixOS:master Jan 13, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.