Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv2odf: init at 2.09 #77471

Merged
merged 1 commit into from Jan 16, 2020
Merged

csv2odf: init at 2.09 #77471

merged 1 commit into from Jan 16, 2020

Conversation

@leenaars
Copy link
Contributor

@leenaars leenaars commented Jan 10, 2020

Motivation for this change

Useful command line tool to insert csv files in ODF spreadsheets.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

quite a bit of nit's ;(

pkgs/applications/office/csv2odf/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/csv2odf/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/csv2odf/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/csv2odf/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/csv2odf/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/csv2odf/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/csv2odf/default.nix Outdated Show resolved Hide resolved
@leenaars leenaars force-pushed the leenaars:csv2odf branch from 7814c97 to 065ce72 Jan 12, 2020
@leenaars
Copy link
Contributor Author

@leenaars leenaars commented Jan 12, 2020

@jonringer: accepted all of them, thanks for reviewing and these changes.

@leenaars leenaars force-pushed the leenaars:csv2odf branch from 065ce72 to 501eebb Jan 13, 2020
@leenaars leenaars requested a review from jonringer Jan 14, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commits LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77471
1 package built:
csv2odf
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 16, 2020

@GrahamcOfBorg build csv2odf

@jonringer jonringer merged commit edfbac4 into NixOS:master Jan 16, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
csv2odf on aarch64-linux Success
Details
csv2odf on x86_64-darwin Success
Details
csv2odf on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.