Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mynewt-newt: 1.3.0 -> 1.7.0, use buildGoModule #77516

Merged
merged 2 commits into from Feb 1, 2020
Merged

Conversation

@Thra11
Copy link
Contributor

@Thra11 Thra11 commented Jan 11, 2020

Motivation for this change

Update mynewt-newt to 1.7.0. Switch from legacy buildGoPackage to buildGoModule

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Thra11
Copy link
Contributor Author

@Thra11 Thra11 commented Jan 11, 2020

Looks like 1.7.0 has a bug which prevents newt upgrade working with mcuboot (Unreleased workaround/fix is here apache/mynewt-newt@7d4ef3f). Not sure if we should patch it or just wait for a release...

@Thra11 Thra11 force-pushed the Thra11:mynewt-newt branch from c824735 to 1646b59 Jan 11, 2020
@kalbasit
Copy link
Member

@kalbasit kalbasit commented Jan 11, 2020

@Thra11 Does 1.7.0 work well with the patch applied? It's probably ok to update it with the patch if it works well.

@Thra11
Copy link
Contributor Author

@Thra11 Thra11 commented Jan 12, 2020

I had to cherry pick an additional commit for the fix to apply cleanly. Having done that, it builds and seems to work. I tried

  1. Removing my existing mynewt installation
  2. Switching to the 1.3.0 version of the package and running newt install
  3. Switching to the patched 1.7.0 version of the package and running newt upgrade
    It seems to have worked ok, where the unpatched version failed.
@Thra11 Thra11 force-pushed the Thra11:mynewt-newt branch from 3abcf48 to eb0c48b Jan 31, 2020
@ofborg ofborg bot requested a review from kalbasit Jan 31, 2020
@kalbasit
Copy link
Member

@kalbasit kalbasit commented Feb 1, 2020

@GrahamcOfBorg build mynewt-newt

@kalbasit kalbasit merged commit 05d62c1 into NixOS:master Feb 1, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mynewt-newt on aarch64-linux Success
Details
mynewt-newt on x86_64-darwin Success
Details
mynewt-newt on x86_64-linux Success
Details
@Thra11 Thra11 deleted the Thra11:mynewt-newt branch Feb 1, 2020
anna328p added a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
mynewt-newt: 1.3.0 -> 1.7.0, use buildGoModule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.