Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibus-engines.table-others: 1.3.9 -> 1.3.11 #77517

Merged
merged 1 commit into from Jan 18, 2020
Merged

ibus-engines.table-others: 1.3.9 -> 1.3.11 #77517

merged 1 commit into from Jan 18, 2020

Conversation

@McSinyx
Copy link
Contributor

@McSinyx McSinyx commented Jan 11, 2020

Motivation for this change

Update ibus-table-others to version 1.3.11 with the following changes:

  • Add Vietnamese input methods Telex and VNI
  • Extend russian translit for latin slavic layouts
  • latex: add most of Unicode 9.0 block Mathematical Alphanumeric Symbols
  • mathwriter-ibus: add superscript alphabets
  • mathwriter-ibus: added Blackboard bold letters
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@laMudri
Copy link
Contributor

@laMudri laMudri commented Jan 11, 2020

Just a version bump; should be fine. I'm not sure how much I need to do as a reviewer. It'd be nice to know if you've tested one of the new/modified input methods on your machine.

@McSinyx
Copy link
Contributor Author

@McSinyx McSinyx commented Jan 12, 2020

I'm currently using a Vietnamese table and it's working as expected.

@nh2 nh2 merged commit 5cda709 into NixOS:master Jan 18, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ibus-engines.table-others on aarch64-linux Success
Details
ibus-engines.table-others on x86_64-linux Success
Details
@McSinyx McSinyx deleted the McSinyx:ibus-table-others-1-3-11 branch Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.