Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: include the rustc-dev component #77529

Merged
merged 1 commit into from Jan 12, 2020
Merged

rust: include the rustc-dev component #77529

merged 1 commit into from Jan 12, 2020

Conversation

@symphorien
Copy link
Contributor

@symphorien symphorien commented Jan 11, 2020

This enables to compile rls and rustc

See also rust-lang/rust#64823

Fixes #77108 and probably #77358

I tested a version of this patch with more debugging, but I didn't want to do yet another 3+ hour build just to check that it still works without set -x.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This enables to compile rls and rustc

See also rust-lang/rust#64823
@LnL7
LnL7 approved these changes Jan 12, 2020
@LnL7 LnL7 merged commit 05d4cdf into NixOS:staging Jan 12, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@symphorien symphorien deleted the symphorien:rls branch Jan 12, 2020
@curiousleo
Copy link
Contributor

@curiousleo curiousleo commented Jan 13, 2020

This fixes #77358. I'm in favour of getting this merged into master, but I'm not sure what the procedure for that is. I'd appreciate it if whoever gives the go-ahead for merging this change into master could ping this PR so I'm aware. Thanks!

@LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 13, 2020

This will end up in master with the staging-next iteration after #77047, along with everything else that was merged to staging since.

@curiousleo
Copy link
Contributor

@curiousleo curiousleo commented Jan 13, 2020

This will end up in master with the staging-next iteration after #77047, along with everything else that was merged to staging since.

I can't see anything related to rust in https://github.com/NixOS/nixpkgs/pull/77047/commits or https://github.com/NixOS/nixpkgs/pull/77047/files.

@LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 13, 2020

This was created after the current iteration started, it will be included in the next one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.