Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgsStatic: make OpenSSL 1.1 compile #77542

Merged
merged 3 commits into from Jan 16, 2020

Conversation

@anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Jan 12, 2020

Motivation for this change

I've been using this in my own overlays and it's working well for me. Opening a PR to get feedback and to have it built by CI in case I'm overlooking something.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
openssl = (super.openssl_1_1.override { static = true; }).overrideAttrs (o: {
configureFlags = (removeUnknownConfigureFlags o.configureFlags) ++ [
"no-shared"
];

This comment has been minimized.

@nh2

nh2 Jan 12, 2020
Contributor

Please explain the rationale of the above with comments, otherwise others will just find unexplained magic incantations :)

This comment has been minimized.

@anmonteiro

anmonteiro Jan 12, 2020
Author Member

makes sense, done in a new commit!

# See https://wiki.openssl.org/index.php/Compilation_and_Installation#Configure_Options
# for a comprehensive list.
configureFlags = (removeUnknownConfigureFlags o.configureFlags) ++ [
"no-shared"

This comment has been minimized.

@FRidh

FRidh Jan 12, 2020
Member

could we move this into the openssl expression and add it in case static == true

This comment has been minimized.

@anmonteiro

anmonteiro Jan 12, 2020
Author Member

Hey @FRidh, thanks for your review. That does make sense, as with all the other derivations.

I (obviously) missed that when porting over from my own overlay. Just pushed a new commit that moves the static configuration to the openssl derivation.

@anmonteiro
Copy link
Member Author

@anmonteiro anmonteiro commented Jan 16, 2020

@FRidh friendly ping

@FRidh FRidh merged commit 4b34c18 into NixOS:master Jan 16, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Profpatsch added a commit to Profpatsch/nixpkgs that referenced this pull request Jan 21, 2020
* pkgsStatic: make OpenSSL 1.1 compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.