Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mycli: Add paramiko as a propagated build input #77546

Merged
merged 1 commit into from Feb 6, 2020
Merged

Conversation

@wigust
Copy link
Contributor

@wigust wigust commented Jan 12, 2020

Fixes error:

Cannot use SSH transport because paramiko isn't installed, please
install paramiko or don't use --ssh-host=
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Fixes error:

    Cannot use SSH transport because paramiko isn't installed, please
    install paramiko or don't use --ssh-host=
Copy link
Member

@jojosch jojosch left a comment

LGTM. Built and tested using NixOS 20.03pre208857.e4134747f56 and local MySQL over SSH.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

[2 built, 6 copied (0.9 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77546
1 package built:
mycli
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 13, 2020

however, looking at the package:

    extras_require={
        'ssh':  ['paramiko'],
    },

generally optional dependencies are left to the user to add.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 13, 2020

But, argument for merging this is that it's an application, so it's not as easy to insert a dependency as it is with a python module. Also, the closure impact is pretty minimal:

$ nix path-info -Sh ./results/mycli
/nix/store/dcyldiiw54sw7ilgk1yk77sbrr1rp4fw-mycli-1.20.1	 143.0M
$ nix path-info -Sh ./result
/nix/store/6h4dhkh50v6vj39diz42yk6g2h89q23r-mycli-1.20.1	 140.2M
@jonringer jonringer requested a review from FRidh Jan 13, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 13, 2020

@GrahamcOfBorg build mycli

@FRidh
Copy link
Member

@FRidh FRidh commented Feb 6, 2020

In the end it's really up to the maintainer to decide what should be in the base package and what not. Given @jojosch approved it I'm merging this.

@FRidh FRidh merged commit 9405324 into NixOS:master Feb 6, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mycli on aarch64-linux Success
Details
mycli on x86_64-darwin Success
Details
mycli on x86_64-linux Success
Details
@wigust wigust deleted the wigust:mycli-paramiko branch Feb 6, 2020
@wigust wigust restored the wigust:mycli-paramiko branch May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.