Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.XMLTwig: install xml_grep #77558

Merged
merged 1 commit into from Mar 10, 2020
Merged

Conversation

@raboof
Copy link
Contributor

@raboof raboof commented Jan 12, 2020

Motivation for this change

Make tools tools that come with XML-Twig available when installing perlPackages.XMLTwig

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@aanderse aanderse left a comment

@raboof the xml_spellcheck tool won't work with this as it references aspell. There may or may not be issues with other tools too, xml_spellcheck was the only one I noticed after briefly looking.

@raboof raboof force-pushed the raboof:xmlTwigTools branch from afa5543 to 24554d9 Feb 29, 2020
@raboof raboof changed the title perlPackages.XMLTwig: install tools like xml_grep perlPackages.XMLTwig: install xml_grep Feb 29, 2020
@raboof
Copy link
Contributor Author

@raboof raboof commented Feb 29, 2020

the xml_spellcheck tool won't work with this as it references aspell. There may or may not be issues with other tools too, xml_spellcheck was the only one I noticed after briefly looking.

Fair enough, reduced the scope of the PR to just xml_grep, which is the one I was interested in. That one definitely works for me.

@raboof raboof requested a review from aanderse Feb 29, 2020
@aanderse
Copy link
Contributor

@aanderse aanderse commented Feb 29, 2020

No interest in including aspell? If not that is fine, but it should be a simple sed to include it... I'm good either way.

@aanderse aanderse requested a review from volth Feb 29, 2020
@raboof
Copy link
Contributor Author

@raboof raboof commented Feb 29, 2020

No interest in including aspell?

I wasn't sure people would like growing the number of run-time dependencies of the package, and since I personally wasn't interested in that one I took the easy way out ;)

@aanderse
Copy link
Contributor

@aanderse aanderse commented Feb 29, 2020

@GrahamcOfBorg build perldevelPackages.XMLTwig perlPackages.XMLTwig

@aanderse
Copy link
Contributor

@aanderse aanderse commented Mar 10, 2020

@raboof sorry I lost track of this. Circling back now... can you look into the failed builds please?

@raboof raboof force-pushed the raboof:xmlTwigTools branch from 24554d9 to 8ff6ae6 Mar 10, 2020
@raboof
Copy link
Contributor Author

@raboof raboof commented Mar 10, 2020

@GrahamcOfBorg build perldevelPackages.XMLTwig perlPackages.XMLTwig

@raboof
Copy link
Contributor Author

@raboof raboof commented Mar 10, 2020

Oh, I missed the failures entirely. They didn't seem familiar, so I just rebased on lastest nixos-unstable - now it seems fine...

@aanderse aanderse merged commit 7836b04 into NixOS:master Mar 10, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
perlPackages.XMLTwig, perldevelPackages.XMLTwig on aarch64-linux Success
Details
perlPackages.XMLTwig, perldevelPackages.XMLTwig on x86_64-darwin Success
Details
perlPackages.XMLTwig, perldevelPackages.XMLTwig on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.