Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp-netlib: remove insecure openssl dependency and unnecessary asio #77568

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@bhipple
Copy link
Contributor

@bhipple bhipple commented Jan 12, 2020

Upstream openssl has dropped support for 1.0.2; see #77503 for details. This
also cleans up the old asio dependency, which now comes from boost, and
documents why the test driver fails.

CC @vcunat

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Upstream openssl has dropped support for 1.0.2; see #77503 for details. This
also cleans up the old `asio` dependency, which now comes from `boost`, and
documents why the test driver fails.
'';

# Most tests make network GET requests to various websites
doCheck = false;

This comment has been minimized.

@bhipple

bhipple Jan 12, 2020
Author Contributor

All of this is a no-op change from the status quo, since doCheck = false is the default. However, I spent some time getting the test driver to at least execute and pass some tests (with above preCheck hook), and felt like it was worth documenting. A handful of tests pass, but a significant enough majority try to do something like GET https://github.com that I felt like it wasn't worth going through and patching them all out.

@bhipple
Copy link
Contributor Author

@bhipple bhipple commented Jan 12, 2020

@GrahamcOfBorg build cpp-netlib

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

[2 built, 1 copied (11.9 MiB), 1.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77568
1 package built:
cpp-netlib
@Mic92 Mic92 merged commit 2c96282 into NixOS:master Jan 13, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
cpp-netlib on aarch64-linux Success
Details
cpp-netlib on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 13, 2020
cpp-netlib: remove insecure openssl dependency and unnecessary asio
(cherry picked from commit 2c96282)
@bhipple bhipple deleted the bhipple:fix/cpp-netlib-openssl branch Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.