gitstatus: patch fewer characters #77580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup to NixOS#76744. The patch is still too aggressive because it captures additional local variables declared in the same line. It should stop when it hits whitespace. See romkatv/gitstatus#92.
ryneeverett
force-pushed
the
gitstatus-patch-even-fewer-lines
branch
from
d98eeac to
be4efc8
Compare
ryneeverett
changed the title
Patching in the GITSTATUS_DAEMON variable seems like a more stable solution than doing inline replacements.
|
Works for me! Thank you for fixing this. |
|
Looking at gitstatus' source code is seems to also have a non-zsh version of this which could be installed as well in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #76744.
The patch is still too aggressive because it captures additional local
variables declared in the same line. It should stop when it hits
whitespace.
Even better, patching in the
GITSTATUS_DAEMONvariable seems like a more stablesolution than doing inline replacements.
See romkatv/gitstatus#92.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)@mmlb