Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axel: enable darwin #77593

Merged
merged 1 commit into from Jan 13, 2020
Merged

axel: enable darwin #77593

merged 1 commit into from Jan 13, 2020

Conversation

@lionello
Copy link
Contributor

@lionello lionello commented Jan 13, 2020

Motivation for this change

Wanted axel on MacOS.

Things done

Changed platforms to unix to support building on Darwin.

This was previously changed by @LnL7 in c195e52 to limit to Linux. This derivation appears to work fine on Darwin now.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This derivation appears to work fine on Darwin.
@lionello
Copy link
Contributor Author

@lionello lionello commented Jan 13, 2020

@LnL7 do you remember why you had limited this to Linux in c195e52?

Copy link
Contributor

@jonringer jonringer left a comment

commit message should be:

axel: enable darwin
@jonringer jonringer changed the title Allow building on Darwin alex: enable darwin Jan 13, 2020
@jonringer jonringer changed the title alex: enable darwin axel: enable darwin Jan 13, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 13, 2020

@GrahamcOfBorg build axel

@Mic92 Mic92 merged commit c926ef8 into NixOS:master Jan 13, 2020
3 checks passed
3 checks passed
axel on aarch64-linux Success
Details
axel on x86_64-darwin Success
Details
axel on x86_64-linux Success
Details
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Jan 13, 2020

Fixed commit title by squashing.

@LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 13, 2020

@lionello Was broken for over a year and couldn't find anything straightforward to fix it https://hydra.nixos.org/job/nixpkgs/trunk/axel.x86_64-darwin/all.

dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 29, 2020
This derivation appears to work fine on Darwin.

(cherry picked from commit c926ef8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.