Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libselinux: Fix cross-compilation with Python 3 #77596

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@samueldr
Copy link
Member

@samueldr samueldr commented Jan 13, 2020

Motivation for this change

Fixes cross compilation, after #75668.

Without this, the python used somehow is the target python, and not the build python. Not sure what changed between python3 and python2 that made this a new issue.

With #77525 and this, Mobile NixOS stage-1 builds correctly on the tip of staging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@samueldr
Copy link
Member Author

@samueldr samueldr commented Jan 13, 2020

Ah, @lopsided98 explained it, I believe, in #75668 already. See #49526.

@Mic92 Mic92 merged commit c6fed21 into NixOS:staging Jan 13, 2020
@samueldr samueldr deleted the samueldr:fix/cross/libselinux-python3 branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.