Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gobetween: init at 0.7.0 #77597

Merged
merged 1 commit into from Jan 28, 2020
Merged

gobetween: init at 0.7.0 #77597

merged 1 commit into from Jan 28, 2020

Conversation

@tomberek
Copy link
Contributor

@tomberek tomberek commented Jan 13, 2020

Motivation for this change

Include a dynamic proxy into nixpkgs.

Things done

Build with buildGo112Module due to errors with go 1.13 (upstream is aware, issues filed).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tomberek tomberek force-pushed the tomberek:tomberek/gobetween branch from e76aa10 to 2f3ec68 Jan 13, 2020
pkgs/servers/gobetween/default.nix Outdated Show resolved Hide resolved
rev = "7d8a7368a535641df273c6b962750c1113d0c6b0";
sha256 = "628e9a3f37aa12f3c54ef7b81a707ea732179a0aa7bb621b8cd833535f27546e";
};
modSha256 =

This comment has been minimized.

@jonringer

jonringer Jan 13, 2020
Contributor

should be one line, and please put a space between that and src

Suggested change
modSha256 =
modSha256 =

This comment has been minimized.

@tomberek

tomberek Jan 13, 2020
Author Contributor

added space. long line is split by nixfmt, it does look odd, but i'm trying to apply nixfmt as much as possible. I can change if it's a problem.

@tomberek tomberek force-pushed the tomberek:tomberek/gobetween branch 2 times, most recently from 2dcb4f5 to 62e5d66 Jan 13, 2020
Copy link
Contributor

@jonringer jonringer left a comment

I do notice that the version is wrong, not sure if there's an easy way to fix this:

$ ./results/gobetween/bin/gobetween --help
gobetween v0.8.0+snapshot
Modern & minimalistic load balancer for the Cloud era
@tomberek
Copy link
Contributor Author

@tomberek tomberek commented Jan 14, 2020

Not sure about that. Seems like that’s an upstream tagging error. I can fish around for a more internally consistent commit, or bother upstream to tag 0.8.0.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 16, 2020

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM, but commits needs to be squashed https://nixos.org/nixpkgs/manual/#submitting-changes-making-patches

git reset HEAD^
git add pkgs/
git commit --amend --no-edit
@tomberek tomberek force-pushed the tomberek:tomberek/gobetween branch from 7feccb7 to 4fe893b Jan 18, 2020
@tomberek
Copy link
Contributor Author

@tomberek tomberek commented Jan 18, 2020

Squashed. Thanks for the assist.

@tomberek tomberek force-pushed the tomberek:tomberek/gobetween branch from 4fe893b to 08421c2 Jan 18, 2020
@ofborg ofborg bot requested a review from kalbasit Jan 18, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 18, 2020

@GrahamcOfBorg build gobetween

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

I'll merge in a day if @kalbasit doesn't have any issues

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Jan 26, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/109

@marsam marsam merged commit de6df13 into NixOS:master Jan 28, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gobetween on aarch64-linux Success
Details
gobetween on x86_64-darwin Success
Details
gobetween on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
anna328p added a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.