Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.solo-python: 0.0.18 -> 0.0.21 #77611

Merged
merged 1 commit into from Jan 13, 2020
Merged

Conversation

@wucke13
Copy link
Contributor

@wucke13 wucke13 commented Jan 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
+ fixes 74835
@wucke13 wucke13 requested review from FRidh and jonringer as code owners Jan 13, 2020
@wucke13
Copy link
Contributor Author

@wucke13 wucke13 commented Jan 13, 2020

@GrahamcOfBorg build python3Packages.solo-python
@GrahamcOfBorg eval python3Packages.solo-python

Copy link
Member

@prusnak prusnak left a comment

LGTM

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

[4 built, 14 copied (3.1 MiB), 0.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77611
2 package built:
python37Packages.solo-python python38Packages.solo-python
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 13, 2020

@GrahamcOfBorg build python37Packages.solo-python python38Packages.solo-python

@jonringer jonringer merged commit 57d0c81 into NixOS:master Jan 13, 2020
4 of 5 checks passed
4 of 5 checks passed
python37Packages.solo-python, python38Packages.solo-python on aarch64-linux
Details
python37Packages.solo-python, python38Packages.solo-python on x86_64-darwin Success
Details
python37Packages.solo-python, python38Packages.solo-python on x86_64-linux Success
Details
python3Packages.solo-python on aarch64-linux Success
Details
python3Packages.solo-python on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.