Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.publicsuffix: fix build #77613

Merged
merged 2 commits into from Jan 13, 2020
Merged

python3.pkgs.publicsuffix: fix build #77613

merged 2 commits into from Jan 13, 2020

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Jan 13, 2020

Motivation for this change

This patch has not been necessary since
5425867, and has in fact broken the
build since then.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@alyssais alyssais requested a review from FRidh Jan 13, 2020
@alyssais alyssais requested a review from jonringer as a code owner Jan 13, 2020
This patch has not been necessary since
5425867, and has in fact broken the
build since then.
@alyssais alyssais force-pushed the alyssais:publicsuffix branch from 1f362d4 to dd8bdee Jan 13, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

[4 built, 1 copied (0.1 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77613
3 package built:
python27Packages.publicsuffix python37Packages.publicsuffix python38Packages.publicsuffix
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 13, 2020

@GrahamcOfBorg build python27Packages.publicsuffix python37Packages.publicsuffix python38Packages.publicsuffix

@jonringer jonringer merged commit d184039 into NixOS:master Jan 13, 2020
3 checks passed
3 checks passed
python27Packages.publicsuffix, python37Packages.publicsuffix, python38Packages.publicsuffix on aarch64-linux Success
Details
python27Packages.publicsuffix, python37Packages.publicsuffix, python38Packages.publicsuffix on x86_64-darwin Success
Details
python27Packages.publicsuffix, python37Packages.publicsuffix, python38Packages.publicsuffix on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.