Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk3: 3.24.12 -> 3.24.13 #77621

merged 1 commit into from Jan 13, 2020

gtk3: 3.24.12 -> 3.24.13 #77621

merged 1 commit into from Jan 13, 2020


Copy link

@hedning hedning commented Jan 13, 2020

Motivation for this change

This one slipped through the cracks for some reason.

News in 3.24.13:

  • listbox: Fix header row reuse

  • wayland: Fix handling of tablets

  • theme:

    • Adwaita: Fix menu rounding
    • Adwaita: Various improvements for the Emoji chooser
    • Adwaita: Refresh check and radio buttons
    • HighContrast: Fix entry colors
  • input:

    • Properly handle bubbling of scroll events
    • Handle modifier key events properly
    • Run key controllers in the bubble phase
    • Do not use VIQR for Vietnamese by default
  • statusicons: Render sharply on hi-dpi

  • wayland: Fix handling of selection ownership

  • win32:

    • Set WS_BORDER for fullscreen GL windows if requested
    • Fix clipboard handling
  • quartz:

    • Handle titlebar events properly
    • Handle page up/down key events properly
  • broadway: Fix (lack of) clipboard handling

  • Translation updates:
    Chinese (Taiwan)

Things done

Built on top of master.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@dtzWill dtzWill commented Jan 13, 2020

Thanks! Been working for me (3e59784, same hash woo haha) for the few days I've been using it.

@dtzWill dtzWill merged commit 55fc8e1 into NixOS:staging Jan 13, 2020
@hedning hedning deleted the hedning:gtk3-3.24.13 branch Jan 13, 2020
Copy link
Contributor Author

@hedning hedning commented Jan 16, 2020

Gah, forgot to check darwin of course, it fails on staging-next now: The log is gone for some reason, but I'm guessing this is the problem:

Copy link
Contributor Author

@hedning hedning commented Jan 17, 2020

OK, pretty straightforward to fix: #77917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.