Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gildas: 20191201_a -> 20200101_a #77631

Merged
merged 1 commit into from Jan 17, 2020
Merged

gildas: 20191201_a -> 20200101_a #77631

merged 1 commit into from Jan 17, 2020

Conversation

@smaret
Copy link
Contributor

@smaret smaret commented Jan 13, 2020

Motivation for this change

Update gildas to the latest upstream, and replace Python 2 by Python 3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bzizou
bzizou approved these changes Jan 14, 2020
@smaret smaret force-pushed the smaret:gildas-202001a branch from 344f442 to 0956fca Jan 14, 2020
@ofborg ofborg bot requested a review from bzizou Jan 14, 2020
@smaret smaret marked this pull request as ready for review Jan 14, 2020
@smaret
Copy link
Contributor Author

@smaret smaret commented Jan 14, 2020

nix-review pr passes on both macOS and Linux (Debian).

@bzizou
bzizou approved these changes Jan 14, 2020
@veprbl
Copy link
Member

@veprbl veprbl commented Jan 17, 2020

@GrahamcOfBorg build gildas

@veprbl veprbl merged commit 430dfb8 into NixOS:master Jan 17, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gildas on aarch64-linux Success
Details
gildas on x86_64-darwin Success
Details
gildas on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@smaret smaret deleted the smaret:gildas-202001a branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.