Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated vim packages #77659

Closed
wants to merge 1 commit into from
Closed

Updated vim packages #77659

wants to merge 1 commit into from

Conversation

@softinio
Copy link
Member

@softinio softinio commented Jan 14, 2020

Motivation for this change

Updated vim packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@softinio
Copy link
Member Author

@softinio softinio commented Feb 2, 2020

Gave up waiting for review and merge especially now it requires a rebase. Will submit again some other day.

@softinio softinio closed this Feb 2, 2020
@softinio softinio deleted the softinio:vim-updates branch Feb 2, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 2, 2020

sorry about my response, been busy with personal life stuff, and a lot of stuff got dropped :(

@softinio
Copy link
Member Author

@softinio softinio commented Feb 2, 2020

@jonringer no problem at all I get OSS as I contribute regularly.

How do I become a codeowner/merger so I can help you and nix? This way load isn't just on you :-)

FYI areas I am happy to help in are all things vim, python and scala related.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 2, 2020

to get commit access, I don't think there's a set requirements, more or less this is done organically by how often people feel that your reviews are aligned with good practices and maintaining code quality. Since nixpkgs is a mono-repo, commit access does kind of give you keys to the castle, so there's not a lot of desire to give it out freely. See #50105 for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.