Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marktext: init #77694

Merged
merged 1 commit into from Jan 15, 2020
Merged

marktext: init #77694

merged 1 commit into from Jan 15, 2020

Conversation

@nh2
Copy link
Contributor

nh2 commented Jan 14, 2020

Motivation for this change

https://marktext.app is a great editor.

Long-term it would be great to package it without using the AppImage binary release (see marktext/marktext#1647), but until that's done, this is a workaround.

I used the notable package by @dtzWill as a template. It is also an AppImage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nh2 nh2 requested a review from dtzWill Jan 14, 2020
@nh2 nh2 self-assigned this Jan 14, 2020
@nh2 nh2 mentioned this pull request Jan 14, 2020
This uses the .AppImage binary release, until we have a real source package
(see marktext/marktext#1647).

I used the `notable` package as a template.
@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Jan 14, 2020

LGTM! It'd be best to not package an -rc2 release, but personally I'd rather have it that way than not at all :). Any idea if there is likely a new stable release soon?

@nh2

This comment has been minimized.

Copy link
Contributor Author

nh2 commented Jan 15, 2020

It'd be best to not package an -rc2 release, but personally I'd rather have it that way than not at all :). Any idea if there is likely a new stable release soon?

I agree in principle but the RC2 fixes some issues that make using the app a big pain to use (https://github.com/marktext/marktext/releases/tag/v0.16.0-rc.2), so I've packaged (and tested) this as the first version that's useful to me.

I'll upgrade it once the non-RC 0.16.0 is out.

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Jan 15, 2020

@nh2 nh2 merged commit 81c2cc9 into NixOS:master Jan 15, 2020
15 checks passed
15 checks passed
marktext on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
marktext on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.