Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.clubhouse-cli: init at 2.1.0 #77705

Closed
wants to merge 2 commits into from

Conversation

@tobim
Copy link
Contributor

@tobim tobim commented Jan 14, 2020

Motivation for this change

I'm using this at work.
https://github.com/andjosh/clubhouse-cli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@@ -363,7 +363,7 @@ let
npm ${forceOfflineFlag} --nodedir=${nodeSources} ${npmFlags} ${stdenv.lib.optionalString production "--production"} rebuild
if [ "''${dontNpmInstall-}" != "1" ]
if [ "$dontNpmInstall" != "1" ]
Copy link
Contributor Author

@tobim tobim Jan 14, 2020

This change was done by the script. I'm not sure this is OK.

@prusnak
Copy link
Member

@prusnak prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@ryantm
Copy link
Member

@ryantm ryantm commented Oct 16, 2020

merged via #100606

@ryantm ryantm closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants