Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pillow: 6.2.1 -> 7.0.0 #77714

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@evanjs
Copy link
Member

evanjs commented Jan 15, 2020

Motivation for this change

7.0.0 (2020-01-02)

Support for Python 2.7 has been dropped


Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

python -m PIL confirms 7.0.0

--------------------------------------------------------------------
Pillow 7.0.0
Python 3.7.6 (default, Dec 18 2019, 19:23:55)
       [GCC 9.2.0]
--------------------------------------------------------------------
...

This feature was introduced in python-pillow/Pillow#3870, so running python -m PIL before 7.0.0 will print: python3.7: No module named PIL.__main__; 'PIL' is a package and cannot be directly executed

nix-shell -p nixpkgs-review --run "nixpkgs-review wip" passed, but is there anything more in depth I can do to test reverse dependencies or etc?

The only thing I can think of is any libraries that might depend on this but don't require python2.7, etc.

@evanjs evanjs requested review from FRidh and jonringer as code owners Jan 15, 2020
@evanjs evanjs changed the title Pillow 7.0.0 pythonPackages.pillow: 6.2.1 -> 7.0.0 Jan 15, 2020
@ofborg ofborg bot requested a review from cillianderoiste Jan 15, 2020
Copy link
Contributor

jonringer left a comment

please also squash the commits

pythonPackages.pillow: drop support for python2.7
- Support for Python 2.7 was removed in Pillow 7.0.0
 - https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst#700-2020-01-02
@evanjs evanjs force-pushed the evanjs:pillow-7.0.0 branch from 0b8d717 to 72f9a98 Jan 15, 2020
@evanjs

This comment has been minimized.

Copy link
Member Author

evanjs commented Jan 15, 2020

@jonringer anything else you can think of?

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 16, 2020

no, LGTM. However, it takes forever to nix-review this because of all downstream dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.