Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpie: 1.0.3 -> 2.0.0 #77722

Merged
merged 1 commit into from Jan 15, 2020
Merged

httpie: 1.0.3 -> 2.0.0 #77722

merged 1 commit into from Jan 15, 2020

Conversation

@bbigras
Copy link
Contributor

bbigras commented Jan 15, 2020

Motivation for this change

update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md

I only tested http-prompt quickly. A simple GET worked.

$ nix path-info -h -S /nix/store/zakzw9m8pcp1z2lf7i4lvk34naybx9na-httpie-1.0.3
/nix/store/zakzw9m8pcp1z2lf7i4lvk34naybx9na-httpie-1.0.3 115.8M

$ nix path-info -h -S /nix/store/jscqy7pkcqrj9zhy1rjshhsz7vhj99z2-httpie-2.0.0
/nix/store/jscqy7pkcqrj9zhy1rjshhsz7vhj99z2-httpie-2.0.0 115.9M

@lsix
lsix approved these changes Jan 15, 2020
Copy link
Member

lsix left a comment

Built and tested !

All fine for me.

Thanks

@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Jan 15, 2020

Just done a quick reading of upstream changelog, it mentions:

Added tests/ to the PyPi package for the convenience of downstream package maintainers.

Does it change our test phase? Maybe there is more or better testing available.

@bbigras bbigras force-pushed the bbigras:httpie branch from b2683c1 to 50e6d33 Jan 15, 2020
@bbigras

This comment has been minimized.

Copy link
Contributor Author

bbigras commented Jan 15, 2020

Does it change our test phase? Maybe there is more or better testing available.

I would guess it only affects people using the pypi package (like if we used fetchPypi instead of fetchFromGitHub). We currently got tests running from the tests folder when building the package.

But it seems we can remove the disabledTests. test_current_version doesn't seem to exist anymore and test_error seems to pass.

tests/test_docs.py seems to be skipped even with export PATH=${docutils}/bin:$PATH.

@bbigras

This comment has been minimized.

Copy link
Contributor Author

bbigras commented Jan 15, 2020

It seems the problem is that httpie now use a virtual env (venv) which is not set up or it's missing docutils.

Should we set up that env properly or patch it out?

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Jan 15, 2020

tests/test_docs.py seems to be skipped even with export PATH=${docutils}/bin:$PATH.

Does it work if you add docutils to checkInputs?

@bbigras bbigras force-pushed the bbigras:httpie branch from 50e6d33 to 8858cc1 Jan 15, 2020
@bbigras

This comment has been minimized.

Copy link
Contributor Author

bbigras commented Jan 15, 2020

Does it work if you add docutils to checkInputs?

No. I think it's because python's path is hardcoded:
https://github.com/jakubroztocil/httpie/blob/a7e52287129a8f61826b9c1e6b4c61ab11861b1f/tests/test_docs.py#L42-L51

I added a patch to fix that but for some reason the test doesn't fail if I remove export PATH=${docutils}/bin:$PATH.

@Mic92 Mic92 merged commit a98371a into NixOS:master Jan 15, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
httpie on aarch64-linux Success
Details
httpie on x86_64-linux Success
Details
@bbigras bbigras deleted the bbigras:httpie branch Jan 15, 2020
@bbigras

This comment has been minimized.

Copy link
Contributor Author

bbigras commented Jan 15, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.