Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.google_cloud_storage: propagate setuptools #77742

Closed

Conversation

@idontgetoutmuch
Copy link
Contributor

idontgetoutmuch commented Jan 15, 2020

This is used during runtime.

cc #68314

Motivation for this change

See https://github.com/NixOS/nixpkgs/pull/70900/commits

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This is used during runtime.

cc #68314
@idontgetoutmuch idontgetoutmuch requested a review from FRidh as a code owner Jan 15, 2020
@ofborg ofborg bot added the 6.topic: python label Jan 15, 2020
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Jan 15, 2020

This is targeting an incorrect branch. If its for 19.09, then it should target release-19.09.

@ofborg ofborg bot requested a review from costrouc Jan 15, 2020
@idontgetoutmuch idontgetoutmuch deleted the idontgetoutmuch:nixos-19.09 branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.