Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-analyzer: init at unstable-2020-01-29 #77752

Open
wants to merge 3 commits into
base: master
from

Conversation

@oxalica
Copy link
Contributor

oxalica commented Jan 15, 2020

Motivation for this change

Add rust-analyzer, an experimental modular compiler frontend for the Rust language.
Also add the vscode extension.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@arcnmx

This comment has been minimized.

Copy link
Contributor

arcnmx commented Jan 15, 2020

It might be nice if we could split this up into an unwrapped and wrapped derivation. rustcSrc makes a fair dent in the closure size when it might just be overridden and unused (my typical use of it is to wrap it as part of a shell for a specific rust channel).

Also someone with ofborg permissions may want to initiate a darwin build. In the past I've had to include buildInputs = optionals hostPlatform.isDarwin [ darwin.cf-private darwin.apple_sdk.frameworks.CoreServices ]; but haven't checked in a while if it's still necessary.

Finally, not an important point, but I wondered if we could/should build it with the jemalloc feature? I think features still can't be combined with cargo's -p flag yet though so :(

Copy link
Contributor

jonringer left a comment

I would split this into two commits:

rust-analyzer: init at unstable-2020-01-13
vscode-extensions.rust-analyzer: init at unstable-2020-01-13
@oxalica oxalica force-pushed the oxalica:rust-analyzer branch from a0d5488 to b8a799f Jan 18, 2020
@oxalica

This comment has been minimized.

Copy link
Contributor Author

oxalica commented Jan 18, 2020

@arcnmx
That's great. But it's not easy to build two packages with features on using a single cargo command. I read the docs of rust-analyzer, and the binary ra_cli is development-only and seems just for benchmarks. To make it easy, I just build the language server ra_lsp_server.
Also, it builds on darwin now.

@jonringer
Splitted.

@oxalica oxalica force-pushed the oxalica:rust-analyzer branch from b8a799f to a7830c3 Jan 21, 2020
@oxalica

This comment has been minimized.

Copy link
Contributor Author

oxalica commented Jan 21, 2020

Updated to 2020-01-20

@oxalica oxalica changed the title rust-analyzer: init at unstable-2020-01-13 rust-analyzer: init at unstable-2020-01-20 Jan 21, 2020
evanjs added a commit to evanjs/nixos_cfg that referenced this pull request Jan 25, 2020
- wait until rust-analyzer is merged into nixpkgs
  (NixOS/nixpkgs#77752)
@oxalica oxalica force-pushed the oxalica:rust-analyzer branch 2 times, most recently from 703cc08 to 2164a0f Jan 29, 2020
@oxalica

This comment has been minimized.

Copy link
Contributor Author

oxalica commented Jan 29, 2020

  • Rebased and updated to unstable-2020-01-29.
  • Make the vscode extension to use unstable- prefixed version of rust-analyzer, since it is also unstable.
  • Add maintainers.
  • Some tiny fixes.
@oxalica oxalica changed the title rust-analyzer: init at unstable-2020-01-20 rust-analyzer: init at unstable-2020-01-29 Jan 29, 2020
@oxalica

This comment has been minimized.

Copy link
Contributor Author

oxalica commented Feb 10, 2020

Latest version 2020-02-10 is blocked by #79148, which is merged into staging but not in master yet.

@oxalica oxalica force-pushed the oxalica:rust-analyzer branch from 2164a0f to 6b07f4a Feb 15, 2020
@oxalica

This comment has been minimized.

Copy link
Contributor Author

oxalica commented Feb 15, 2020

Rebased and bumped to 2020-02-11.
Also fixed update script.

oxalica added 3 commits Jan 29, 2020
@oxalica oxalica force-pushed the oxalica:rust-analyzer branch from 6b07f4a to 3b79878 Feb 25, 2020
@oxalica

This comment has been minimized.

Copy link
Contributor Author

oxalica commented Feb 25, 2020

Bumped to 2020-02-25 and fix binary name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.