Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synergy: 1.8.8 -> 1.11.0 #77761

Closed
wants to merge 1 commit into from
Closed

synergy: 1.8.8 -> 1.11.0 #77761

wants to merge 1 commit into from

Conversation

@Enzime
Copy link
Member

Enzime commented Jan 15, 2020

Motivation for this change

Remove patches that are no longer necessary. Untested on macOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from aszlig Jan 15, 2020
@Enzime Enzime marked this pull request as ready for review Jan 15, 2020
@Enzime Enzime force-pushed the Enzime:update-synergy branch from 3c41068 to c761a3b Jan 15, 2020
pkgs/applications/misc/synergy/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/synergy/default.nix Outdated Show resolved Hide resolved
@Enzime Enzime force-pushed the Enzime:update-synergy branch from c761a3b to 9706335 Jan 17, 2020
@Enzime Enzime requested a review from alyssais Jan 17, 2020
'';

doCheck = true;
checkPhase = "../bin/unittests";

This comment has been minimized.

Copy link
@alyssais

alyssais Jan 17, 2020

Member

Not running the tests any more?

This comment has been minimized.

Copy link
@Enzime

Enzime Jan 19, 2020

Author Member

They used to build automatically, but they removed it from the CMake, I've opened a corresponding issue here:

symless/synergy-core#6620

@Enzime Enzime requested a review from alyssais Jan 20, 2020
@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Jan 20, 2020

@GrahamcOfBorg build synergy

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Jan 20, 2020

The patch for Darwin no longer applies. Could you check if it still looks necessary, and either update it or delete it? If we can’t figure out how to actually build this on Darwin that’s okay, but we should at least get beyond patchPhase.

@Enzime

This comment has been minimized.

Copy link
Member Author

Enzime commented Jan 20, 2020

@alyssais Taking a look at it now, I believe the CMakeLists.txt file has changed since I made that patch. I don't have access to a macOS machine to test building synergy. What are your thoughts on leaving the patch there for someone in the future who is interested in fixing this? It may be useful to them even though it doesn't apply, as I suspect that removing the patch, Synergy will still not build on Darwin.

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Jan 20, 2020

Remove patches that are no longer necessary
@Enzime Enzime force-pushed the Enzime:update-synergy branch from 9706335 to 9f9754c Jan 21, 2020
@Enzime

This comment has been minimized.

Copy link
Member Author

Enzime commented Jan 22, 2020

@alyssais Removed the Darwin patch, can you get @GrahamcOfBorg to build it on Darwin?

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Jan 22, 2020

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Feb 10, 2020

Darwin failure.

@Enzime Enzime closed this Feb 21, 2020
@Enzime Enzime deleted the Enzime:update-synergy branch Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.