Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnused: 4.7 -> 4.8 #77766

Merged
merged 1 commit into from Jan 16, 2020
Merged

gnused: 4.7 -> 4.8 #77766

merged 1 commit into from Jan 16, 2020

Conversation

@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented Jan 15, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (centos with nix installed)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Jan 15, 2020

This will need to go to staging, since gnused is part of our stdenv so an update will rebuild all the things. Bot will tag it accordingly shortly, presumably :).

Anyway, mostly wanted to link to the announcement/changelog:

https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00002.html

@matthiasbeyer matthiasbeyer force-pushed the matthiasbeyer:update-sed branch from cd8e8b7 to d35122a Jan 15, 2020
@matthiasbeyer

This comment has been minimized.

Copy link
Contributor Author

matthiasbeyer commented Jan 15, 2020

Rebased, added more information to the commit and pushed.

@ttuegel ttuegel removed their request for review Jan 16, 2020
@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Jan 16, 2020

Needs to go to staging, not staging-next. The README has a description of the staging process, but tl;dr PRs should always be to either master or staging, never staging-next.

@matthiasbeyer matthiasbeyer changed the base branch from staging-next to staging Jan 16, 2020
Upstream announcement:
https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00002.html

For the lazy:

> * Noteworthy changes in release 4.8 (2020-01-14) [stable]
>
> ** Bug fixes
>
>   "sed -i" now creates temporary files with correct umask (limited to u=rwx).
>   Previously sed would incorrectly set umask on temporary files, resulting
>   in problems under certain fuse-like file systems.
>   [bug introduced in sed 4.2.1]
>
> ** Release
>
>   distribute gzip-compressed tarballs once again
>
> ** Improvements
>
>   a year's worth of gnulib development, including improved DFA performance

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer matthiasbeyer force-pushed the matthiasbeyer:update-sed branch from d35122a to db99a2d Jan 16, 2020
@alyssais alyssais merged commit df4ec23 into NixOS:staging Jan 16, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gnused on aarch64-linux Success
Details
gnused on x86_64-darwin Success
Details
gnused on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@matthiasbeyer matthiasbeyer deleted the matthiasbeyer:update-sed branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.