Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosie init at unstable 2020-01-11 #77777

Open
wants to merge 1 commit into
base: master
from

Conversation

@KoviRobi
Copy link
Contributor

KoviRobi commented Jan 15, 2020

Motivation for this change

Packages request #73921. A supercharged alternative to regular expressions (regex), matching patterns against any input text.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Notes

  • Currently Rosie uses its own Lua, so I don't use luaPackages.callPackage (see https://gitlab.com/rosie-pattern-language/rosie/issues/111)
  • Using unstable branch currently, as it contains some fixes for Nix packaging (as a result of previously mentioned gitlab issue).
  • Not using fetchFromGitLab but fetchgit as we need to fetch the submodules
  • Editor plugins have some bugs:
    • Emacs requires (require 'rpl-mode) before being able to M-x rpl-mode
    • Not sure how/where vim plugins should be installed, I tried to replicate something like vimPlugins.syntastic in the output directory but couldn't get it to auto-load using vim_configurable.customize (neovim picks up package from ~/.nix-profile/share/nvim/site when nix-env -i'd)

(It pleases me that this is pull request 77777, just because it's the same digits.)

pkgs/tools/text/rosie/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/rosie/default.nix Outdated Show resolved Hide resolved
stdenv.mkDerivation rec {
pname = "rosie";
version = "unstable-2020-01-11";
src = fetchgit {

This comment has been minimized.

Copy link
@dtzWill

dtzWill Jan 15, 2020

Contributor

Perhaps replace fetchgit with fetchFromGitLab, as that's generally faster than a git clone as fetchgit does.

This comment has been minimized.

Copy link
@KoviRobi

KoviRobi Jan 15, 2020

Author Contributor

Can't, need to fetch submodules, fetchFromGitLab doesn't do that

This comment has been minimized.

Copy link
@KoviRobi

KoviRobi Jan 21, 2020

Author Contributor

I did have an alternative, which used fetchFromGitLab/fetchFromGitHub with the submodules, perhaps I should resurrect it: KoviRobi@0dcbc21

@KoviRobi

This comment has been minimized.

Copy link
Contributor Author

KoviRobi commented Jan 15, 2020

As for platforms, it should in theory work with Darwin too, but I don't have access to anything but linux (x86_64), not sure if I should restrict it to linux until someone can test it

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Jan 15, 2020

It uses its own Lua (making it use a generic Lua is work-in-progress).
@KoviRobi KoviRobi force-pushed the KoviRobi:rosie-init-at-unstable-2020-01-11 branch from b1bddc5 to 51e137b Jan 17, 2020
@KoviRobi

This comment has been minimized.

Copy link
Contributor Author

KoviRobi commented Jan 17, 2020

Added platforms to be linux and darwin, I used a colleague's laptop to test it too, so it works not just builds :)

Anything else?

@KoviRobi

This comment has been minimized.

Copy link
Contributor Author

KoviRobi commented Jan 22, 2020

New bugfix release coming soon, so I will change this from the unstable when that's out

@KoviRobi

This comment has been minimized.

Copy link
Contributor Author

KoviRobi commented Jan 22, 2020

A small niggle is the emacs & vim syntax highlight files. The neovim works, no idea about vanilla vim, emacs works if you do (require 'rpl-mode), but not otherwise despite it having ;;;###autoload cookies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.