Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vit: fix check phase #77781

Merged
merged 1 commit into from Jan 15, 2020
Merged

vit: fix check phase #77781

merged 1 commit into from Jan 15, 2020

Conversation

@arcnmx
Copy link
Contributor

arcnmx commented Jan 15, 2020

Motivation for this change

It broke. See a6d0b81 for a similar fix for a different package affected by the same issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Jan 15, 2020

LGTM, this is how I had it from the start-- not sure how it failed to make it here, sorry. I can say it works, though! ^_^

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Jan 15, 2020

Unfortunately, python3Packages.tasklib doesn't seem to be building for me on this revision-- I wonder if it builds for you/hydra/anyone if we try it again? Maybe another 2020 bug?

Well, no matter. This looks good for now :).

@arcnmx

This comment has been minimized.

Copy link
Contributor Author

arcnmx commented Jan 15, 2020

Hm, I can force a rebuild of python3Packages.tasklib on nixos-unstable-small and current master on my own machine and it seems to complete without issues.

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Jan 15, 2020

Well, then certainly isn't worth worrying about re:this PR then :). Thanks for checking!

@dtzWill dtzWill merged commit 712bf54 into NixOS:master Jan 15, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vit on aarch64-linux Success
Details
vit on x86_64-linux Success
Details
@arcnmx arcnmx deleted the arcnmx:vit-fix branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.